Skip to content

Update Mesa easyblock to use not use removed swrast as gallium driver for Mesa versions >= 25.x#3790

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Micket:20250619233344_new_pr_mesa
Jul 3, 2025
Merged

Update Mesa easyblock to use not use removed swrast as gallium driver for Mesa versions >= 25.x#3790
boegel merged 2 commits intoeasybuilders:developfrom
Micket:20250619233344_new_pr_mesa

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Jun 19, 2025 •
edited
Loading

(created using eb --new-pr)

Lots of old code here, basically all of swr and swrast is long dead now, but since we keep old versions still, i'm leaving it in just in case there is some odd OS out there. But really, it should just be llvmpipe (or softpipe for those who can't use LLVM, which is noone).

In the future, we should just drop all the swr code and swrast logic here, and just set it to use llvmpipe and be done with it.

@Micket Micket added the bug fix label Jun 19, 2025
@Micket Micket added this to the next release (5.1.1?) milestone Jun 19, 2025
@Micket Micket mentioned this pull request Jun 19, 2025
Merged
3 tasks
branfosj
branfosj previously requested changes Jun 20, 2025
View reviewed changes
@Micket @branfosj
Update easybuild/easyblocks/m/mesa.py
d1b0a4b 
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Jun 20, 2025 •
edited
Loading

Was able to get forward, we probably also need to fix the sanity check this is what i get after building

there where also other needed deps, gonna add them and make a PR soon

Failing the sanity check with

ERROR: Installation of 123.eb failed: "Sanity check failed: no file found at 'lib/libOSMesa.so' in /home/crivella/.local/easybuild/software/Mesa/25.1.3-GCCcore-14.2.0\nno file found at 'include/GL/osmesa.h' in /home/crivella/.local/easybuild/software/Mesa/25.1.3-GCCcore-14.2.0"

crivella@crivella-desktop:~/.local/easybuild/software/Mesa/25.1.3-GCCcore-14.2.0$ ls lib
dri                   libgbm.so             libGLX_mesa.so.0.0.0
gbm                   libgbm.so.1           libVkLayer_MESA_device_select.so
libEGL_mesa.so        libgbm.so.1.0.0       libvulkan_lvp.so
libEGL_mesa.so.0      libGLX_indirect.so.0  pkgconfig
libEGL_mesa.so.0.0.0  libGLX_mesa.so
libgallium-25.1.3.so  libGLX_mesa.so.0

dri                   libgbm.so             libGLX_mesa.so.0.0.0
gbm                   libgbm.so.1           libVkLayer_MESA_device_select.so
libEGL_mesa.so        libgbm.so.1.0.0       libvulkan_lvp.so
libEGL_mesa.so.0      libGLX_indirect.so.0  pkgconfig
libEGL_mesa.so.0.0.0  libGLX_mesa.so
libgallium-25.1.3.so  libGLX_mesa.so.0

@boegel boegel changed the title Update Mesa easyblock to use not use removed swrast Update Mesa easyblock to use not use removed swrast as gallium driver for Mesa versions >= 25.x Jul 3, 2025
boegel
boegel approved these changes Jul 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 3, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Mesa-22.0.3-GCCcore-11.3.0.eb
  • SUCCESS Mesa-24.1.3-GCCcore-13.3.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3527.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/30cb8ef3044e55a7fddd2ebdc2c096b8 for a full test report.

@boegel boegel dismissed branfosj’s stale review July 3, 2025 19:26

requested change done

@boegel boegel merged commit 50c118f into easybuilders:develop Jul 3, 2025
17 checks passed
@boegel boegel added update and removed bug fix labels Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@branfosj branfosj branfosj left review comments

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

5.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Micket @Crivella @boegel @branfosj